Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-18329: Add jointcal wcs and photoCalib templates. #86

Merged
merged 1 commit into from Mar 8, 2019

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Mar 8, 2019

No description provided.

jointcal_wcs: # astrometric calibration produced by jointcal
template: jointcal-results/%(filter)s/%(tract)04d/jointcal_wcs-%(visit)07d-%(raftName)s-%(detectorName)s-det%(detector)03d.fits
jointcal_photoCalib: # photometric calibration produced by jointcal
template: jointcal-results/%(filter)s/%(tract)04d/jointcal_photoCalib-%(visit)07d-%(raftName)s-%(detectorName)s-det%(detector)03d.fits
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need raftName, detectorName and detector in here? Wouldn't either the first two, or just the last one, be sufficient?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Maybe @jchiang87 can chime in because he wrote these, but if you look at the rest of the policy file this seems to be the standard template, including the raw exposure template. So I think it should be left as-is, and whether to simplify this would have to be decided at another level.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did try just specifying the first two, and I recall it failing for me, though I don't remember the exact issue. In any case, as Eli notes, I just followed the convention for the other templates and everything worked fine.

Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess a little redundancy never hurt anybody.

@erykoff erykoff merged commit d0696a0 into master Mar 8, 2019
@timj timj deleted the tickets/DM-18329 branch May 12, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants