DM-17866: Add support for BOT/lsstCam #87
Conversation
There was a problem hiding this comment.
My main comment is that I can't figure out the scope of this set of changes, and would like a the original Jira ticket to be clearer! From off-line discussion with @timj I believe that this PR makes it possible to ingest BOT data as lsstCam, and its the job of someone else (probably @rhl) to change the lsstCam yaml files to reflect the current state of the camera at SLAC.
Two minor in-line comments
| # Do not yet have a header explicitly for this. | ||
| program = None | ||
| if "TSTAND" in self._header and "DAYOBS" in self._header: | ||
| program = self._header["DAYOBS"] |
There was a problem hiding this comment.
Can we set program to None or "unknown" or something rather than DAYOBS? I don't think that program has any LSST meaning, and we shouldn't be relying on it.
There was a problem hiding this comment.
This gets converted to gen2 run concept and ingest fails if run is None so I have to pick something. LSST does have a science program meaning since we will be distinguishing between all the deep drilling fields and fast/wide/deep. This definition of run is consistent with what is happening in HSC translation.
There was a problem hiding this comment.
I'll switch to "unknown" (we used dayObs for UCD translator).
| for filename, expected in test_data: | ||
| with self.subTest(f"Testing {filename}"): | ||
| self.assertObservationInfoFromYaml(filename, dir=self.datadir, **expected) | ||
|
|
There was a problem hiding this comment.
What is this testing? On the face if it, that we can read ordered dicts from yaml but there must be something more. A doc string would help
There was a problem hiding this comment.
This is standard boiler plate for astro_metadata_translator testing. The raw headers are read in and translated and the results of the translation are compared with the supplied dict.
In particular the bulk of lsstsim.py has been moved to lsst.py since it is not simulator-specific code.
LsstCamMapper is now a subclass of LsstBaseMapper. This allows the specific translation classes to be specified.
Also remove testType since it's the same as imgType.
No description provided.