DM-18708: Add support for BOT RUNNUM and FILTER2 headers #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use shared routine and support FILTER, FILTER1 and FILTER2.
Needed for BOT testing.
SimonKrughoff
approved these changes
Apr 1, 2019
| headers. Returns "NONE" if no filter is declared. | ||
| """ | ||
| filterNames = [] | ||
| for k in ("FILTER", "FILTER1", "FILTER2"): |
There was a problem hiding this comment.
Is there any way to make this configurable so you don't have to edit code to add a filter?
There was a problem hiding this comment.
astro_metadata_translator translators should not depend on pex_config. Also, obs_lsst cameras are not meant to be using different filter keywords at every opportunity.
There was a problem hiding this comment.
I didn't necessarily mean using pex_config. You can do what you want, I just noticed that was one of the changes in this change set (adding a filter).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.