DM-18643: Rename referenceSelection to referenceSelector and change default field to "resolved" #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your commit message first line is a bit too long. |
|
I guess I clean that up in a rebase? |
|
Interactive rebase and then |
morriscb
requested changes
Apr 10, 2019
config/imsim/singleFrameDriver.py
Outdated
| config.processCcd.calibrate.astrometry.referenceSelection.unresolved.name = 'isresolved' | ||
| config.processCcd.calibrate.astrometry.referenceSelection.unresolved.minimum = None | ||
| config.processCcd.calibrate.astrometry.referenceSelection.unresolved.maximum = 0.5 | ||
| config.processCcd.calibrate.astrometry.referenceSelector.doUnresolved = True |
There was a problem hiding this comment.
Having the configs duplicated between ProcessCcd and here could lead to different behaviors between the pipelines if the configs change. Take a look at https://github.com/lsst/obs_subaru/blob/master/config/singleFrameDriver.py for an example of how to handle this.
config/phosim/singleFrameDriver.py
Outdated
| config.processCcd.calibrate.astrometry.referenceSelection.unresolved.name = 'isresolved' | ||
| config.processCcd.calibrate.astrometry.referenceSelection.unresolved.minimum = None | ||
| config.processCcd.calibrate.astrometry.referenceSelection.unresolved.maximum = 0.5 | ||
| config.processCcd.calibrate.astrometry.referenceSelector.doUnresolved = True |
morriscb
approved these changes
Apr 11, 2019
The field was called "isresolved" previously due to a miscommunication. This has been fixed at the same time as updating the config parameter name from referenceSelection to referenceSelector.
erykoff
force-pushed
the
tickets/DM-18643
branch
from
5610ccb
to
428c829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field was called "isresolved" previously due to a miscommunication. This
has been fixed at the same time as updating the config parameter name.