Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-21186: Rename AuxTel to LATISS #1

Merged
merged 1 commit into from Sep 6, 2019
Merged

DM-21186: Rename AuxTel to LATISS #1

merged 1 commit into from Sep 6, 2019

Conversation

timj
Copy link
Member

@timj timj commented Sep 5, 2019

The defects are associated with the camera and not the telescope.

Copy link

@mfisherlevine mfisherlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latiss or LATISS - I'm not sure. If you are then go ahead and merge 🙂

@timj
Copy link
Member Author

timj commented Sep 6, 2019

Yes. Regarding the name, the problem is that in obs_lsst there is a strong preference to using the lower case name in all files and directory names (or at least camelCase). Unfortunately the defects support code in obs_base has an internal check that the instrument defined in the header of the ecsv files matches the directory name and it doesn't do a case insensitive comparison. I therefore have to use the wrong instrument name in the ECSV file or be inconsistent in the directory naming scheme. Or else I fix obs_base. @SimonKrughoff how would you feel if we made the directory name comparison case insensitive?

@timj
Copy link
Member Author

timj commented Sep 6, 2019

Actually pipe_tasks now that I look again.

@timj
Copy link
Member Author

timj commented Sep 6, 2019

I made a PR in pipe_tasks which I hope we can accept to clean up this change.

@mfisherlevine
Copy link

Oh, cool! You will be unsurprised to hear that I don't care very much really though, was just pointing it out in case it was a mistake.

@mfisherlevine
Copy link

Also - fun fact on a controversial opinion I hold: case should be allowed, but everything should case-insensitive, all the time. Not even joking.

@timj
Copy link
Member Author

timj commented Sep 6, 2019

@mfisherlevine that's why you love macOS so much with your case preserving case insensitive file systems...

The defects are associated with the camera and not the telescope.
@timj timj merged commit ff89408 into master Sep 6, 2019
@timj timj deleted the tickets/DM-21186 branch September 6, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants