Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42513: Add transmission_sensor, transmission_filter, and transmission_optics data for comCamSim #16

Merged
merged 7 commits into from Feb 24, 2024

Conversation

jchiang87
Copy link
Contributor

No description provided.

Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments. A larger comment is that the filter transmissions from the throughputs repo have what I don't think are reliable numbers outside the main wavelength coverage.

In the obs_lsst package, one then runs the script to write the files
using the througputs data:
```
cd python ${OBS_LSST_DIR}/python/lsst/obs/lsst/script/write_comCamSim_filter_files.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think cd is correct here.

In the obs_lsst package, one then runs the script to write the files
using the througputs data:
```
cd python ${OBS_LSST_DIR}/python/lsst/obs/lsst/script/write_comCamSim_optics_file.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cd?

@jchiang87 jchiang87 merged commit 239af97 into main Feb 24, 2024
3 checks passed
@jchiang87 jchiang87 deleted the tickets/DM-42513 branch February 24, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants