Disable subimage access to raws.

Gen2 seems to have have always done this incorrectly given that
the flipping that happens in std_raw should have been considered
when interpreting the bounding boxes.  In Gen3 we'll instead refuse
to do it (unless we decide we need it later).

This does slow down a unit test (because we need to read a full file
in it).

python/lsst/obs/subaru/gen3/hsc/rawFormatter.py

@@ -48,6 +48,12 @@ def makeWcs(self, metadata):
         return makeFlippedWcs(wcs, self.FLIP_LR, self.FLIP_TB, center)
 
     def readImage(self, fileDescriptor):
+        if fileDescriptor.parameters:
+            # It looks like the Gen2 std_raw code wouldn't have handled
+            # flipping vs. subimages correctly, so we won't bother to either.
+            # But we'll make sure no one tries to get a subimage, rather than
+            # doing something confusing.
+            raise NotImplementedError("Formatter does not support subimages.")
         image = ImageU(fileDescriptor.location.path)
         return flipImage(image, self.FLIP_LR, self.FLIP_TB)
 

tests/test_ingest.py

@@ -28,8 +28,6 @@
 import shutil
 import lsst.utils.tests
 
-from lsst.afw.image import LOCAL
-from lsst.afw.geom import Box2I, Point2I
 from lsst.daf.butler import Butler
 from lsst.obs.base.gen3 import RawIngestTask
 from lsst.obs.subaru.gen3.hsc import HyperSuprimeCam
@@ -75,10 +73,9 @@ def runIngest(self, files=None):
 
     def runIngestTest(self, files=None):
         self.runIngest(files)
-        parameters = dict(origin=LOCAL, bbox=Box2I(Point2I(0, 0), Point2I(2, 2)))
-        exposure = self.butler.get("raw", self.dataId, parameters=parameters)
+        exposure = self.butler.get("raw", self.dataId)
         metadata = self.butler.get("raw.metadata", self.dataId)
-        image = self.butler.get("raw.image", self.dataId, parameters=parameters)
+        image = self.butler.get("raw.image", self.dataId)
         self.assertImagesEqual(exposure.image, image)
         self.assertEqual(metadata.toDict(), exposure.getMetadata().toDict())