DM-245: Implement HSC camera in new camera framework #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is 4 commits behind master, and cannot be automatically merged. It should be rebased against master. |
Updates genDefectFits.py to use the new CameraGeom format. This also required a change in the hsc SConstruct file to match the new API. Also repairs capitalizatio issue in scons file.
The new camera objects use XYTransforms to map from one coordinate system to another. This means that the DistEst distortion code needs to be wrapped up in an XYTransform. The XYTransform is exposed in python by adding an entry to the XYTransformRegistry.
The old camera objects were built from policy files. This is no longer required, but since the representation was available we continue to use the policy file as the starting point for building camera registries (the persisted files used by the mapper to build a camera). Also, the transform registry is different between hsc and suprimecam. This makes the repo generation respect this.
This commit also updates the mapper policy files to point to the new camera repository.
This utility can display parts of the camera all the way to the whole mosaic. It currently only works with HSC. There is another utility called showCamera that overlaps with this utility. It can probably be removed, or it should be updated to work with the new cameraGeom.
The use of std_camera was re-defined in the current master CameraMapper.
…tements in processCcd.py and hsc/processCcd.py Removed those measurements that are not defined on the LSST side.
As per a previous code review requesting overloading of "order" to mean either polynomial order or spline knots.
Polymorphism of detector-like objects was removed, so casts are not necessary.
… getRawHorizontalOverscanBBox
CCD 9 has lost another amplifier (now 2 out of 4). This update will allow us to process S14A and S14B data without hacking the mapper etc.
Move defect definition of CCD 9 == 1_47, amp 3 to new file in the directory when that amp got bad (2014-04-03). validStart will be set to that date. Conflicts: bin/genDefectRegistry.py hsc/defects/2013-01-31/defects.dat
genDefectRegistry: support multiple versions of same CCD defects Multiple versions of the same CCD defects were thrown in the database with the same end date (way in the future), so that the query to find the defect ended up with multiple rows. Instead, have one defect valid until the next, and only the last is valid into the future. Conflicts: bin/genDefectRegistry.py
…expectation The function bypass_defects wants the FITS header "name" to be equivalent to the detectorName. Also removed creation of the superfluous header "SERIAL".
Only the last defects FITS file was being built. Naming them distinctly, and making them all dependencies of the registry ensures they are all built.
Amplifier linearity parameters are now read in from the hsc_geom.paf policy file and stored in the curretnly available AmpInfoTable fields: linearityType and linearityCoeffs. These may be changed when the linearity corrections are defined and implemented in LSST.
Also changes the variable the key is being compared to to be detConfig.serial which is what NNN is referring to (rather than detConfig.name).
shutil is required for the --clobber command line option.
Now reads in Linearity Parameters from AmpInfoTable
Delete local maskDefect function in favor of using the (essentially identical) maskAndInterpDefect function in ip_isr's isrTask.py. Use doDefect config clause when calling maskAndInterpDefect. Set doDefect config default to True.
…ce to CCD 50, amp 1
…t try to query the registry by tract Conflicts: policy/HscMapper.paf
Conflicts: config/assembleCoadd.py
These are left over from hscMosaic, which is no longer used.
…a failure for good seeing data.
The superclass CameraMapper attempts to set the midtime from MJD-OBS, but HSC uses MJD-STR.
…nter stars especially for g-band.
The bad pixels (e.g., saturation) will otherwise bias the median; this can be severe when there's a bright source close to the edge of the amp.
A recent update in fitsthumb changed the API. The format is no longer provided and I've removed it completely as the butler uses png. To do otherwise would mean the '_filename' returned by a butler.get() would be incorrect. Also, createFitsThumb() now takes an ndarray.
Amps that are completely saturated do not provide any useful information for the crosstalk correction, and using them taints the good amps (NANs or mask). This shouldn't affect the result, as the image is completely saturated and there's not much information there to use in the correction.
In addition to new source catalogs, also includes config, metadata and schema entries for the new CmdLineTasks.
Couldn't have more than one bias or dark in the registry
("RintimeError: No unique lookup for bias from ['calibDate', 'calibVersion'] from {'filter': 'NONE', 'ccd': 108, 'visit': 1136}: 2 matches").
Adding validty ranges fixes this.
Now calls lsst.afw.display.ds9 directly.
Approximately half of the HSC CCDs are rotated 180 deg with respect to the others. Two others have 90 deg rotations and another two have 270 deg rotations . Their associated calibration frames thus need to be rotated prior to applying the corrections.
laurenam
force-pushed
the
tickets/DM-245
branch
from
52651ae
to
746852a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a github pull request for reviewing DM-245.