DM-12947: constructFlat.py fails on HSC #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API in afw for transforms between different coordinate frames (including detector pixels <--> focal plane) changed, so we need to adapt.
Calculating the focal-plane offset of each pixel is very slow (it always has been, but it seems slower with the new Transform API), but the new Transform API allows us to vectorise the calculation.
TallJimbo
approved these changes
Dec 7, 2017
| xyFocalPlane = transform.applyForward(xyDetector) | ||
| origin = afwGeom.Point2D(self.config.vignette.xCenter, self.config.vignette.yCenter) | ||
| r2 = np.array([pp.distanceSquared(origin) for pp in xyFocalPlane]) | ||
| isBad = (r2 > self.config.vignette.radius**2).reshape((h, w)) |
There was a problem hiding this comment.
What kind of numbers are we looking at for numPixels here? If we're allocating multiple temporaries as big as a CCD, we might want to chunk things up.
There was a problem hiding this comment.
Actually, it looks like we were already allocating temporaries of the same size, so this is nothing new, right?
There was a problem hiding this comment.
numPixels is ~8M (2k x 4k). I don't think it's a big deal: we allocate larger temporaries in other places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.