tickets/DM-12697 #101
Merged
tickets/DM-12697 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschella
reviewed
Dec 11, 2017
| config.doNImage = True | ||
|
|
||
| config.assembleStaticSkyModel.badMaskPlanes = ("BAD", "EDGE", "SAT", "INTRP", "NO_DATA",) |
There was a problem hiding this comment.
Why is "NO_DATA" not kept here? The commit message does seem to imply it is.
There was a problem hiding this comment.
See change in pipe_tasks. The Non-camera-specific defaults is reset there. These are just the camera-specific overrides.
pschella
reviewed
Dec 11, 2017
| config.doMaskBrightObjects = True | ||
| config.removeMaskPlanes.append("CROSSTALK") |
There was a problem hiding this comment.
Slightly confusing on this ticket, but doesn't really matter.
There was a problem hiding this comment.
Was hoping that the separate commit and message made it clear it is something missed from DM-12665.
Removing all types of bad pixels (e.g. SAT, INTRP) from the PSF-Matched template coadd can remove the last available epochs from the template for small numbers of epochs. Bad pixels are still removed from the resulting CompareWarp Coadd.
yalsayyad
force-pushed
the
tickets/DM-12697
branch
from
c022a77
to
7463216
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.