Tickets/dm 12700 #115
Merged
Tickets/dm 12700 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
continued from DM-13260.
yalsayyad
force-pushed
the
tickets/DM-12700
branch
2 times, most recently
from
4b2b149
to
318c03c
Compare
TallJimbo
reviewed
Feb 9, 2018
config/coaddDriver.py
Outdated
| config.assembleCoadd.retarget(CompareWarpAssembleCoaddTask) | ||
|
|
||
| # configs specific to CompareWarpAssembleCoaddTask | ||
| config.assembleCoadd.assembleStaticSkyModel.subregionSize = (10000, 200) |
There was a problem hiding this comment.
Why is this being set here? I wouldn't have thought there was anything special about the CoaddDriver + CompareWarp combination.
There was a problem hiding this comment.
Because it's laoding the configs from config/assembleCoadd.py instead of config/compareWarpAssembleCoadd.py.
As lines 6-9 are written, changing "assembleCoadd" --> "compareWarpAssembleCoadd" doesn't work, because it will then try to do: config.compareWarpAssembleCoadd.<configs> which of course isn't the name of the subtask. (this was actually that last thing that I changed back after I posted the review). Actually, a better solution is to loop over tuples of the subtask name and config file name. I'll do that.
yalsayyad
force-pushed
the
tickets/DM-12700
branch
from
318c03c
to
faec93f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.