DM-7886: pyfits to astropy #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
approved these changes
Jul 10, 2018
bin.src/showPsfs.py
Outdated
| @@ -249,8 +249,8 @@ def main(dataDir, visit, title="", outputTxtFileName=None, | |||
| plt.axis([-20000, 20000, -20000, 20000]) | |||
|
|
|||
| def frameInfoFrom(filepath): | |||
| import pyfits | |||
| with pyfits.open(filepath) as hdul: | |||
| from astropy.io import fits | |||
There was a problem hiding this comment.
Please consider moving this import to the top of the file. It's more standard and easier to find there. Also I think main always calls frameInfoFrom.
Astropy prefers that pyfits name is only used for large codebases that were built with pyfits. In this case there are only a couple of lines to edit so use the modern form.
It is always going to be imported so we use the standard location.
timj
force-pushed
the
tickets/DM-7886-obs_subaru
branch
from
04ee37d
to
ecb1b8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.