DM-15189: Initial implementation of Gen3 raw-data ingest #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Aug 22, 2018
tests/test_ingest.py
Outdated
| TESTDIR = os.path.dirname(__file__) | ||
|
|
||
|
|
||
| skipIfNoData = unittest.skipIf(testDataDirectory is None, "testdata_subaru must be set up") |
There was a problem hiding this comment.
Since none of the tests run if data are not available it might be less repetitive to put the skip in setUpClass or setUp.
There was a problem hiding this comment.
Ah, I didn't realize the skip decorators worked on classes, too. Will do.
There was a problem hiding this comment.
I haven't looked deeply but skipping at the class level vs during setUp might result in different skip statistics. I don't remember if there is a difference.
TallJimbo
force-pushed
the
tickets/DM-15189
branch
from
f0e52a2
to
b212d93
Compare
TallJimbo
force-pushed
the
tickets/DM-15189
branch
from
b212d93
to
6a39156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strongly recommend looking at each of the two commits here separately; one is almost entirely just moving code around.