DM-17195: Fix missing INST-PA message for y-band data. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Jan 14, 2019
timj
changed the title
|
The rule is that *nothing* ever comes from headers/metadata; anything we need must be captured as instance variables/objects. So I agree with Tim; MJD delenda est.
|
The rewrite of ISR to be more general also attempted to remove as many extra butler calls as possible. However, as ci_hsc does not test y-band data, this caused a hidden bug with the y-straylight correction. The required keywords should not be pulled from the exposure header, but rather from the VisitInfo associated with the exposure.
czwa
force-pushed
the
tickets/DM-17195
branch
from
280343a
to
d2f5b44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rewrite of ISR to be more general also attempted to remove as many
extra butler calls as possible. However, as ci_hsc does not test
y-band data, this caused a hidden bug with the y-straylight
correction. The required keywords should not be pulled from the
exposure header, but rather from the VisitInfo associated with the
exposure. The MJD-STR and MJD-END keywords are still pulled from the
header, so this may need to be revisited if those keywords are moved
into the VisitInfo as well.