Review for DM-4831: Add bright object masks to pipeline outputs #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| config.measurement.plugins["base_PixelFlags"].masksFpAnywhere.append("BRIGHT_OBJECT") | ||
|
|
||
| config.measurement.plugins.names |= ["base_InputCount"] | ||
|
|
There was a problem hiding this comment.
Do we need the extra blank line?
natelust
force-pushed
the
tickets/DM-4831
branch
3 times, most recently
from
8116688
to
dd76f40
Compare
N.b. Don't override previous values of base_PixelFlags, i.e. use append() not an assignment, as previous code may have set config.measurement.plugins["base_PixelFlags"].*
pipe_tasks (HSC-1342) uses the butler to read these files, of type "brightObjectMask" to set a bit mask and flags for bright objects.
natelust
force-pushed
the
tickets/DM-4831
branch
from
dd76f40
to
b9c07be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.