Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-19214: ip_isr crosstalk shouldn't depend on detector hasCrosstalk( )and getCrosstalk() #202

Merged
merged 1 commit into from
Aug 9, 2019
Merged

DM-19214: ip_isr crosstalk shouldn't depend on detector hasCrosstalk( )and getCrosstalk() #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 12 additions & 8 deletions config/hsc/isr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import os.path

from lsst.utils import getPackageDir
from lsst.obs.subaru.crosstalk import SubaruCrosstalkTask
from lsst.obs.subaru.strayLight import SubaruStrayLightTask

config.datasetType = "raw"
Expand Down Expand Up @@ -57,14 +56,19 @@

config.doCrosstalk = True
config.doCrosstalkBeforeAssemble = False
config.crosstalk.retarget(SubaruCrosstalkTask)
# These values from RHL's report on "HSC July Commissioning Data" (2013-08-23)
config.crosstalk.coeffs.values = [
0.0e-6, -125.0e-6, -149.0e-6, -156.0e-6,
-124.0e-6, 0.0e-6, -132.0e-6, -157.0e-6,
-171.0e-6, -134.0e-6, 0.0e-6, -153.0e-6,
-157.0e-6, -151.0e-6, -137.0e-6, 0.0e-6,
config.crosstalk.crosstalkBackgroundMethod = "DETECTOR"
config.crosstalk.useConfigCoefficients = True
# These values from RHL's report on "HSC July Commissioning Data" (2013-08-23).
# This is the transpose of the original matrix used by the SubaruCrosstalkTask,
# as the ISR implementation uses a different indexing.
config.crosstalk.crosstalkValues = [
czwa marked this conversation as resolved.
Show resolved Hide resolved
0.0e-6, -124.0e-6, -171.0e-6, -157.0e-6,
-125.0e-6, 0.0e-6, -134.0e-6, -151.0e-6,
-149.0e-6, -132.0e-6, 0.0e-6, -137.0e-6,
-156.0e-6, -157.0e-6, -153.0e-6, 0.0e-6,
]
config.crosstalk.crosstalkShape = [4, 4]


config.doWidenSaturationTrails = True

Expand Down