DM-3368 #21
Merged
DM-3368 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from lsst.utils import getPackageDir | ||
|
|
||
| config.processCcd.load(os.path.join(getPackageDir("obs_subaru"), "config", "processCcd.py")) | ||
| config.processCcd.load(os.path.join(getPackageDir("obs_subaru"), "config", "hsc", "processCcd.py")) |
There was a problem hiding this comment.
Why is this line present? This looks like a bug. It has the effect of always calling HSC-specific overrides even if processing SuprimeCam data, which means that the HSC-specific overrides are being treated as universal for Subaru and should be here, not in the HSC directory.
There was a problem hiding this comment.
Right, there needs to be a config/hsc/singleFrameDriver.py to pull the HSC-specific overrides.
natelust
force-pushed
the
tickets/DM-3368
branch
2 times, most recently
from
8a84399
to
95dd00b
Compare
natelust
force-pushed
the
tickets/DM-3368
branch
from
95dd00b
to
a8c446b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.