DM-20548: Update HSC's camera geometry to use units of millimeters #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For (historical?) reasons, the obs_subaru camera geometry has been using an effective scaling of "unity" (i.e. plateScale = 1 arcsec/mm, pixelSize = 1 mm). LSST has always preferred to define cameras in their actual physical scaling units and, as of the work being done on DM-19943, the physical scaling is actually required for the initial WCS-from-metadata creation. The situation is remedied here so that all camera definitions are now in their physical units (namely mm for pixelSize and arcsec/mm for plateScale). The distortion coefficients, which where derived assuming the unit scaling, are scaled in the makeHscDistortion() function in lsst.obs.subaru.hsc.transformRegistry to map them into the appropriate physical scaling.
PaulPrice
approved these changes
Aug 21, 2019
bin.src/showCamera.py
Outdated
|
|
||
| def main(camera, sample=20, names=False, showDistortion=True, plot=True, outputFile=None): | ||
| baseFileName = outputFile.rsplit("/")[-1].split(".")[0] if outputFile else None |
There was a problem hiding this comment.
Yes please. Something like: os.path.splitext(os.path.basename(outputFile))[0] should do it.
HSC used to use pixel scaling for the focal plane. This has been updated to use the appropriate plateScale = 11.2 arcsec/mm and pixelSize = 0.015 mm for HSC, so the pickled dataset for test_distortion.py required regenerating.
laurenam
force-pushed
the
tickets/DM-20548
branch
from
46e9ff0
to
632a304
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.