Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-21421 Add Configs for CharacterizeImageTask #228

Merged
merged 1 commit into from Nov 9, 2019
Merged

Conversation

natelust
Copy link
Contributor

@natelust natelust commented Nov 6, 2019

CharacterizeImageTask has a default name of characterizeImage, but
the config override file was named charImage reflecting the variable
name in ProcessCcdTask. This adds config files with the correct
names so that they can be appropriately discovered and loaded.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

ObsConfigDir = os.path.join(getPackageDir("obs_subaru"), "config", "hsc")

charImFile = os.path.join(ObsConfigDir, "charImage.py")
config.load(charImFile)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline is missing from last line

CharacterizeImageTask has a default name of characterizeImage, but
the config override file was named charImage reflecting the variable
name in ProcessCcdTask. This adds config files with the correct
names so that they can be appropriately discovered and loaded.
@natelust natelust merged commit e41b235 into master Nov 9, 2019
@timj timj deleted the tickets/DM-21421 branch February 25, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants