DM-20841: Support for approximating WCS as SIP #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Jan 29, 2020
TallJimbo
approved these changes
Jan 30, 2020
policy/HscMapper.yaml
Outdated
| @@ -121,7 +121,7 @@ exposures: | |||
| tables: | |||
| - raw | |||
| - raw_visit | |||
| template: '%(pointing)05d/%(filter)s/corr/%(tract)04d/CALEXP-%(visit)07d-%(ccd)03d.fits' | |||
| template: '%(pointing)05d/%(filter)s/calibrated/%(tract)04d/CALEXP-%(visit)07d-%(ccd)03d.fits' | |||
There was a problem hiding this comment.
While I realize these are more or less what Furusawa-san used as an example, I wonder if starting these paths with %(tract)04d/calibrated or calibrated/%(tract)04d or making them more like the forced_src paths (which do start with %(pointing)05d - unfortunately, I'd say) in how the tract is specified would be better. Not a big deal either way - mostly I think it's hard to make these much better without changing more, and that's disruptive.
PaulPrice
force-pushed
the
tickets/DM-20841
branch
3 times, most recently
from
6b76965
to
a14a978
Compare
After modernisation, calibrateCatalog doesn't need any configuration tweaks.
PaulPrice
force-pushed
the
tickets/DM-20841
branch
from
a14a978
to
1d61bff
Compare
These are generated by scripts that now live in hscPipe. We don't want the outputs getting mixed in with the uncalibrated data.
PaulPrice
force-pushed
the
tickets/DM-20841
branch
from
1d61bff
to
5986474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.