DM-23526: Fix fgcmcal issues exposed during PDR2 run #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
approved these changes
Feb 19, 2020
There was a problem hiding this comment.
LGTM, but please consider the following guidelines.
À la: https://developer.lsst.io/work/flow.html#review-preparation
The pull request’s name should be formatted as
DM-NNNN: {{JIRA Ticket Title}}
This helps you and other developers find the right pull request when browsing repositories on GitHub.
And https://developer.lsst.io/work/flow.html#git-commit-message-best-practices:
Writing commit summary lines
Messages start with a single-line summary of 50 characters or less. Consider 50 characters as a hard limit; your summary will be truncated in the GitHub UI otherwise.
erykoff
changed the title
erykoff
force-pushed
the
tickets/DM-23526
branch
from
998f32b
to
01eb8e8
Compare
PaulPrice
pushed a commit
to HyperSuprime-Cam/obs_subaru
that referenced
this pull request
Feb 20, 2020
DM-23526: Fix fgcmcal issues exposed during PDR2 run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix an index bug in the default aperture correction slopes.