DM-23699: Update fgcmcal default config format #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
approved these changes
Mar 10, 2020
config/hsc/fgcmFitCycle.py
Outdated
| config.requiredFlag = (0, 0, 0, 0, 0, 0, 0, 0) | ||
| config.bands = ('N387', 'g', 'r', 'i', 'N816', 'z', 'N921', 'y', 'N1010') | ||
| config.fitBands = ['N387', 'g', 'r', 'i', 'N816', 'z', 'N921', 'y', 'N1010'] | ||
| config.requiredBands = [] |
There was a problem hiding this comment.
I think that config overrides that are the default are discouraged.
| config.fitFlag = (1, 1, 1, 1, 1, 1, 1, 1) | ||
| config.requiredFlag = (0, 0, 0, 0, 0, 0, 0, 0) | ||
| config.bands = ('N387', 'g', 'r', 'i', 'N816', 'z', 'N921', 'y', 'N1010') | ||
| config.fitBands = ['N387', 'g', 'r', 'i', 'N816', 'z', 'N921', 'y', 'N1010'] |
There was a problem hiding this comment.
What is the philosophy for tuple vs. list for ListFields?
There was a problem hiding this comment.
I've seen both, and I am pretty sure it doesn't matter...
List configs that depended on band order have been deprecated in favor of dict mappings which are less susceptible to index errors.
erykoff
force-pushed
the
tickets/DM-23699
branch
from
d2dda59
to
ebd5993
Compare
PaulPrice
pushed a commit
to HyperSuprime-Cam/obs_subaru
that referenced
this pull request
Mar 11, 2020
DM-23699: Update fgcmcal default config format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fgcmcal default config format has been updated to remove many possibilities for index errors.