DM-23976: Use the base class implementations for gen3 defects and camera #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
approved these changes
Mar 31, 2020
| filterDefinitions = HSC_FILTER_DEFINITIONS | ||
|
|
||
| def __init__(self, **kwargs): | ||
| super().__init__(**kwargs) | ||
| packageDir = getPackageDir("obs_subaru") | ||
| self.configPaths = [os.path.join(packageDir, "config"), | ||
| os.path.join(packageDir, "config", "hsc")] | ||
| os.path.join(packageDir, "config", self.policyName)] |
There was a problem hiding this comment.
Per my comment in the obs_base PR, self.policyName here could probably be replaced with self.name.lower().
python/lsst/obs/subaru/instrument.py
Outdated
| for defect, dataId in datasetRecords: | ||
| butler.put(defect, datasetType, dataId) | ||
| # Write defects | ||
| self.writeStandardTextCuratedCalibrations(butler) |
There was a problem hiding this comment.
The comment is misleading, I think: it's writing more than just defects, it's whatever is in standardCuratedDatasetTypes.
parejkoj
reviewed
Mar 31, 2020
python/lsst/obs/subaru/instrument.py
Outdated
| universe=butler.registry.dimensions) | ||
| butler.registry.registerDatasetType(datasetType) | ||
| # Write cameraGeom.Camera | ||
| self.writeCameraGeom(butler) |
There was a problem hiding this comment.
I think the comment here is unnecessary, given the method name.
This will write defects and camera geom for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.