DM-24466: Can't run processCcd on multiple CCDs #270
Conversation
plazas
force-pushed
the
tickets/DM-24466
branch
from
952dff6
to
7774a53
Compare
python/lsst/obs/hsc/hscMapper.py
Outdated
| """Return the linearizer. | ||
| """Return a Linearizer() for a particular detector. Linearizer() applies to | ||
| one detector only (i.e., it is detector-specific). When processing multiple | ||
| detectors, a new instance of Lineaizer() will be created each time. |
There was a problem hiding this comment.
Could you please make this docstring follow the numpydoc guidelines?
It would also be helpful to include a little more information about the Linearizer that is being returned.
Specifically, I'd suggest something like:
"""Return a linearizer for the given detector.
On each call, a fresh instance of `Linearizer` is returned; the caller is responsible for initializing it
appropriately for the detector.
Parameters
----------
`datasetType`: ...
`pythonType`: ...
`butlerLocation`: ...
`dataId`: ...
Notes
-----
Linearizers are not saved to persistent storage; rather, they are managed entirely in memory.
On each call, this function will return a new instance of `Linearizer`, which must be managed
(including setting it up for use with a particular detector) by the caller. Calling
`bypass_linearizer` twice for the same detector will return _different_ instances of `Linearizer`,
which share no state.
"""
tests/test_repository.py
Outdated
| lin1 = self.butler.get('linearizer', ccdnum=1) | ||
| lin2 = self.butler.get('linearizer', ccdnum=2) | ||
| self.assertTrue(lin1) | ||
| self.assertTrue(lin2) |
There was a problem hiding this comment.
I'm not sure these assertTrues mean much — what does it mean for a Linearizer to be True?
If you just want to check that you have an object of some sort, I'd suggest assertIsNotNone.
There was a problem hiding this comment.
Aren't you wanting to test that the instances are distinct? (so checking that id(lin1) != id(lin2) ?
There was a problem hiding this comment.
that's the next line...
There was a problem hiding this comment.
I can change it to assertIsNotNone. The original code in this test (before my modifications) had assertTrue.
plazas
force-pushed
the
tickets/DM-24466
branch
from
355d02a
to
5423a6f
Compare
No description provided.