DM-24664: Refactor data ID translation rule system #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dataset type registration now needs to begin and commit its own transaction for concurrency reasons.
parejkoj
reviewed
May 1, 2020
python/lsst/obs/subaru/instrument.py
Outdated
| @@ -45,6 +46,22 @@ | |||
| log = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| class _HscAbstractFilterKeyHandler(KeyHandler): | |||
| """KeyHandler for HSC filter keys that should be mapped to AbstractFilters. | |||
There was a problem hiding this comment.
Is this materially different from PhysicalToAbstractFilterKeyHandler? I don't remember why I kept it around when I was doing the original converter cleanup (if there was a reason beyond that I just missed it), but I think it can just be replaced by that.
There was a problem hiding this comment.
Yup, looks like they're identical. Will drop this one.
TallJimbo
force-pushed
the
tickets/DM-24664
branch
from
4a308e4
to
7ffcf85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.