DM-24946: Propagate detectCoaddSources configs to multiBandDriver #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
approved these changes
May 20, 2020
config/multiBandDriver.py
Outdated
| @@ -3,7 +3,7 @@ | |||
| import os.path | |||
|
|
|||
|
|
|||
| for sub in ("mergeCoaddDetections", "measureCoaddSources", "mergeCoaddMeasurements", "forcedPhotCoadd"): | |||
| for sub in ("mergeCoaddDetections", "measureCoaddSources", "mergeCoaddMeasurements", "forcedPhotCoadd", "detectCoaddSources"): | |||
There was a problem hiding this comment.
I may have put it at the front of the list to reflect the order of operation in multiband.
config/hsc/multiBandDriver.py
Outdated
| @@ -2,7 +2,7 @@ | |||
| import os.path | |||
|
|
|||
|
|
|||
| for sub in ("mergeCoaddDetections", "measureCoaddSources", "mergeCoaddMeasurements", "forcedPhotCoadd"): | |||
| for sub in ("mergeCoaddDetections", "measureCoaddSources", "mergeCoaddMeasurements", "forcedPhotCoadd", "detectCoaddSources"): | |||
There was a problem hiding this comment.
I don’t see a detectCoaddSources.py in config/hsc, but I suppose it doesn’t hurt to add it here given the if clause.
leeskelvin
force-pushed
the
tickets/DM-24946
branch
from
d5ca76b
to
78a0834
Compare
leeskelvin
force-pushed
the
tickets/DM-24946
branch
from
78a0834
to
c2cd53e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.