DM-23983: Cannot apply crosstalk in Gen 3 DECam processing #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
reviewed
May 30, 2020
python/lsst/obs/hsc/hscMapper.py
Outdated
| @@ -225,6 +225,11 @@ def map_linearizer(self, dataId, write=False): | |||
| mapper=self, | |||
| storage=self.rootStorage) | |||
|
|
|||
| def map_crosstalk(self, dataId, write=False): | |||
| """Construct this on-the-fly in Gen2. | |||
There was a problem hiding this comment.
Construct ... what on the fly? A bit more explanation here, please.
There was a problem hiding this comment.
Updated docstring to be clearer:
Fake the mapping for crosstalk.
Crosstalk is constructed from config parameters, but we need Gen2 butlers to be able to respond to requests for it. Returning None provides a response that can be used with the config parameters to generate the appropriate calibration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dummy crosstalk mapper.