DM-24319: Add support for new parquet source tables in fgcmcal #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
requested changes
Jun 18, 2020
| config.doSubtractLocalBackground = True | ||
|
|
||
| config.fgcmLoadReferenceCatalog.refObjLoader.ref_dataset_name = 'ps1_pv3_3pi_20170110' | ||
| config.fgcmLoadReferenceCatalog.refFilterMap = {'g': 'g', 'r': 'r', 'r2': 'r', |
There was a problem hiding this comment.
I was confused by this line and the above filterMap because I believe our LoadReferenceObjectsTask does not need matching filter names to be defined in the filterMap (e.g. how our PS1 refcats work, because most filter names exist in both). Maybe add a comment to that effect, because this is not the same thing?
| config.fgcmOutputProducts.load(os.path.join(os.path.dirname(__file__), | ||
| 'fgcmOutputProducts.py')) | ||
| config.fgcmFitCycle.aperCorrFitNBins = 0 | ||
| config.fgcmFitCycle.useRepeatabilityForExpGrayCutsDict = {'N387': True, |
There was a problem hiding this comment.
Is this "all filters True" or "just these specific filters True"? It's not clear from how the list is made: maybe there's a better way to make that clear? I don't know if using the FilterDefinitions in hscFilters.py might help?
erykoff
force-pushed
the
tickets/DM-24319
branch
from
8ddb30f
to
34ec7e0
Compare
parejkoj
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.