DM-25689: fixes for Gen2->Gen3 repo conversion #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
changed the title
TallJimbo
force-pushed
the
tickets/DM-25689
branch
2 times, most recently
from
8ae3847
to
9761d6f
Compare
- Update mask collection name. - Remove call to writeCameraGeom from ingestStrayLightData. - Add fits extension to the strayLight formatter.
TallJimbo
force-pushed
the
tickets/DM-25689
branch
from
9761d6f
to
42309cd
Compare
laurenam
reviewed
Jul 3, 2020
| @@ -29,6 +29,7 @@ | |||
| class SubaruStrayLightDataFormatter(FileFormatter): | |||
| """Gen3 Butler Formatters for HSC y-band stray light correction data. | |||
| """ | |||
| extension = ".fits" | |||
There was a problem hiding this comment.
Can’t help but be curious...is the stutter (with L34) deliberate?
There was a problem hiding this comment.
No. I fixed it last week and the rebase didn’t notice so added the second one.
There was a problem hiding this comment.
Gah, I saw this before merge, amended the commit to drop that part, and then somehow it came back before I merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.