DM-25849: Update HSC to use jointcal refcat defaults #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-25849
branch
from
98a42e8
to
ea0658f
Compare
parejkoj
force-pushed
the
tickets/DM-25849
branch
from
ea0658f
to
07c9f4d
Compare
|
Look's good. Will you change the commit message to something a little more dramatic, so that it's obvious this is a big behavior change for our DRPs. Something like: "Use default refcat in jointcal: Gaia DR2" I'd prob just scroll past "Clean up jointcal settings" thinking "prob not important" |
yalsayyad
approved these changes
Dec 8, 2020
This changes from the previous PS1 astrometry that HSC had been using until now. Also cleanup config/hsc/jointcal.py vs. config/jointcal.py: the latter is now entirely superfluous.
parejkoj
force-pushed
the
tickets/DM-25849
branch
from
07c9f4d
to
cc384e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.