DM-7378: Updates for Pytest #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames tests in the obs_subaru package to be compliant with the LSST naming convention.
The tests in obs_subaru have been autopep8'd to make them compliant with the LSST PEP8 guidelines.
| """Ensure that we can ingest raw data to a repository.""" | ||
| @requirePackage(TEST_DATA_PACKAGE) | ||
| @unittest.skipIf(testDataPackage is None, "%s not setup"%(testData)) |
There was a problem hiding this comment.
I'd prefer to say "is not available" here so as not to imply a specific tool. Also, spacing around the %.
AstroVPK
force-pushed
the
tickets/DM-7378
branch
2 times, most recently
from
f68454c
to
f8d13bc
Compare
All the tests in obs_subaru have been cleaned to make them runnable under the py.test framework. The tests have also been purged of all deprecated usage of assert_, assertEquals, etc... The decorator to skip tests in testRepository has been replaced with the unittest provided skipIf decorator.
AstroVPK
force-pushed
the
tickets/DM-7378
branch
from
f8d13bc
to
0f2f9ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.