DM-24024: Revisit region padding in HSC Gen3 ingest or visit definition #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original estimate of 4000 was based old "raw" WCS definitions that did not take the full boresight + rotation + cameraGeom (distortion) information into account and old versions of the matchers and fitters used in astrometric calibration. This number should be a small as possible while still ensuring the padding covers the full calibrated footpring for all visits. A reassessment based on the RC2 dataset sees a maximum (jointcal - raw) pixel offset (where only the CCD corners were considered) of ~191 pixels (in tract coordinates with 0.168 arcsec/pixel). This would indicate we might be able to go as low as 200 pixel padding. This analysis is continuing on a larger dataset (the full HSC PDR2) and initial indications point to some slightly higher offsets: the largest seen thus far is ~220 pixels. Thus, to be somewhat conservative, we adopt a padding of 250 pixels (to be reconsidered in the context of the full PDR2 analysis being conducted on DM-28011.
TallJimbo
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.