DM-28985: Update Gen2 calibration policy formats in obs_subaru #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
approved these changes
Mar 1, 2021
The Gen2 obs_subaru policy/HscMapper.yaml defines bias and dark calibrations to be of persistence type ImageF which, by definition, does not have mask or variance planes. On read, these are passed through a standardization step that converts ImageF to an ExposureF by adding empty mask and variance planes. However, as revealed during a test processing the same data in Gen3, it was noted that these planes do indeed exist and are being used and propagated throughout the Gen3 processing. While the ommission in Gen2 processing is likely scientifically insignificant, we should still be using them for a rigorous accounting for and propagation of know sources of measurement errors. The more immediate desire for this change here is that having such (albeit minor) differences puts a dent in our efforts towards acheiving Gen2/Gen3 parity (toward the imminent retirement of the former) through Single Frame Processing. The fix here is to update the bias and dark formats in the policy file from ImageF to MaskedImageF.
laurenam
force-pushed
the
tickets/DM-28985
branch
from
5edb32e
to
0dc4558
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.