DM-6815: Update LSST full-stack processing configuration to match best practice from HSC #35
Conversation
| @@ -19,6 +19,7 @@ | |||
| config.calibrate.astrometry.matcher.maxRotationDeg=1.145916 | |||
| config.calibrate.astrometry.wcsFitter.numRejIter=3 | |||
|
|
|||
| config.charImage.astrometry.wcsFitter.order = 3 | |||
| config.calibrate.astrometry.wcsFitter.order = 3 | |||
There was a problem hiding this comment.
Are there separate charImage and calibrate astrometry runs? If so, we should make sure the settings for both are the same (maybe put them in a loop?).
There was a problem hiding this comment.
You can say
config.charImage.astrometry.wcsFitter.order = 3
config.calibrate.astrometry.wcsFitter.order = config.charImage.astrometry.wcsFitter.order
There was a problem hiding this comment.
Or:
for sub in (config.charImage, config.calibrate):
sub.astrometry.wcsFitter.order = 3
There was a problem hiding this comment.
Is it always true that these should be the same? I presumed there may conceivably be some use case for allowing more/less freedom in the characterize vs. calibrated stages. I'm happy to make the implied desire for using the same value for both here.
There was a problem hiding this comment.
I think all the astrometry settings for both should be the same, so I recommend using a loop over (config.charImage, config.calibrate) and modifying the values in the loop.
This is to match the config overrides in current use for HSC production run processing (HSC stack version 4.0.3).
This default is now being set in ext_shapeHSM_HsmSourceMoments's config/enable.py.
The ext_shapeHSM_HsmSourceMoments task should be run (if available) in both the charImage.measurement and calibrate.measurement stages, and it is in the former that no deblending has been done and the deblendNChild config should be set to an empty string.
laurenam
force-pushed
the
u/lauren/DM-6815
branch
from
7303d30
to
f07f4fb
Compare
meas_mosaic can and should be run for HSC data processing.
laurenam
force-pushed
the
u/lauren/DM-6815
branch
2 times, most recently
from
1b5ffb2
to
88fbbc1
Compare
Our QA analysis scripts make use of this parameter, so run the plugin by default.
laurenam
force-pushed
the
u/lauren/DM-6815
branch
from
88fbbc1
to
dc9f87a
Compare
No description provided.