DM-30342: Add missing detect flags to object table #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffcarlin
approved these changes
May 26, 2021
yalsayyad
reviewed
May 26, 2021
There was a problem hiding this comment.
Because the "merge_*" flags are from the reference catalog, they are not exploded by filter and therefore should not start with a capital letter. I would actually remove the rename rule for merge unless you want a those columns to be the only columns in the table that start with a capital letter. Ew.
|
Actually if the code were smart, it would be a no op. Let's see... |
yalsayyad
force-pushed
the
tickets/DM-30342
branch
from
7d4a07d
to
d2015ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.