DM-30858: Add GAaP to obs_subaru #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalsayyad
reviewed
Jun 23, 2021
config/forcedPhotCcd.py
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| config.measurement.load(os.path.join(os.path.dirname(__file__), "apertures.py")) | |||
| config.measurement.load(os.path.join(os.path.dirname(__file__), "kron.py")) | |||
| config.measurement.load(os.path.join(os.path.dirname(__file__), "gaap.py")) | |||
There was a problem hiding this comment.
Don't turn on here:
- no slow measurement plugin on any per-visit processing.
- Even if it were fast, I'm not sure it makes sense.
Let's talk about it first.
config/gaap.py
Outdated
| @@ -0,0 +1,7 @@ | |||
| # Enablue GAaP (Gaussian Aperture and PSF) colors | |||
| # 'config' is a SourceMeasurementConfig | |||
There was a problem hiding this comment.
This comment isn't universally true
config/gaap.py
Outdated
| @@ -0,0 +1,7 @@ | |||
| # Enablue GAaP (Gaussian Aperture and PSF) colors | |||
yalsayyad
reviewed
Jun 23, 2021
config/measureCoaddSources.py
Outdated
| @@ -4,6 +4,7 @@ | |||
| config.measurement.load(os.path.join(os.path.dirname(__file__), "kron.py")) | |||
| config.measurement.load(os.path.join(os.path.dirname(__file__), "convolvedFluxes.py")) | |||
| config.measurement.load(os.path.join(os.path.dirname(__file__), "hsm.py")) | |||
| config.measurement.load(os.path.join(os.path.dirname(__file__), "gaap.py")) | |||
policy/Object.yaml
Outdated
| # PSF GAaP flux | ||
| GaapPsFlux: | ||
| functor: NanoJansky | ||
| dataset: meas |
There was a problem hiding this comment.
dataset: forced_src if we're running only on forcedPhotCoadd.
|
I got a comment on my email about not wanting to run gaap in |
arunkannawadi
force-pushed
the
tickets/DM-30858
branch
from
71f086a
to
e2ebf0d
Compare
arunkannawadi
force-pushed
the
tickets/DM-30858
branch
2 times, most recently
from
eebce0f
to
64ef76e
Compare
arunkannawadi
force-pushed
the
tickets/DM-30858
branch
from
64ef76e
to
0d646ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.