Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/dm 5503 #37

Merged
merged 4 commits into from Oct 5, 2016
Merged

Tickets/dm 5503 #37

merged 4 commits into from Oct 5, 2016

Conversation

r-owen
Copy link
Contributor

@r-owen r-owen commented Sep 28, 2016

No description provided.

Copy link
Contributor

@PaulPrice PaulPrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, but please make sure ci_hsc passes before merging.

class MakeHscRawVisitInfo(MakeRawVisitInfo):
"""Make a VisitInfo from the FITS header of a Subaru HSC image

Boresight rotation angle is apparently not available.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about INR-STR and INR-END? I think these are "instrument rotator at start" and "instrument rotator at end". There's also INST-PA which must be "instrument position angle".

Copy link
Contributor Author

@r-owen r-owen Sep 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Do you have specifications for any of these? I would like to know exactly what 0 and 90 degrees mean for the orientation of N and E with respect to detector X and Y (assuming sky rotation, which seems most likely, but a similar question for any other kind of rotation).

INSTR-PA is in my sample HSC data, but not my sample sample Suprimecam data. It is probably the angle we want. INR-STR/END change over time and so are likely rotator mount angle (or similar), and if so, not useful enough to record in VisitInfo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no comments on the HSC engineering data I looked at. Here's what I have from a Suprime-Cam frame (SUPA01270732.fits):

INR-STR =               65.186 / [degree] Inst. rotator angle at start          
INR-END =               65.185 / [degree] Inst. rotator angle at end            
INST-PA =               90.000 / Position Angle of Instrument                   

Oooh! A more recent HSC exposure (HSCA08609518.fits) has comments on the headers too:

INR-STR =              -26.982 / [degree] Inst. rotator angle at start          
INR-END =              -26.982 / [degree] Inst. rotator angle at end            
INST-PA =                0.000 / [degree] Position Angle of the Instrument Flang

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The subprime data I have also has that comment; I just don't know what "Position Angle of the Instrument" actually means. I could guess, but it is safer not to!

from __future__ import print_function

import astropy.units
import astropy.time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import.

@r-owen
Copy link
Contributor Author

r-owen commented Sep 30, 2016

I made all suggested changes, rebased and pushed. I documented the possibilities for setting rotator angle but did not implement them yet for lack of necessary information. It is trivial to add this later when the information becomes available.

standardizeCalib is no onger required because lsst.daf.base.exposureFromImage can now do the job.
Note: I also looked for Calib.getExptime, Calib.getMidTime
and Calib.setMidTime but did not find them.
@r-owen r-owen merged commit 78bee59 into master Oct 5, 2016
@ktlim ktlim deleted the tickets/DM-5503 branch August 25, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants