New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tickets/dm 5503 #37
Tickets/dm 5503 #37
Conversation
4fd855b
to
d1d1d11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, but please make sure ci_hsc passes before merging.
class MakeHscRawVisitInfo(MakeRawVisitInfo): | ||
"""Make a VisitInfo from the FITS header of a Subaru HSC image | ||
|
||
Boresight rotation angle is apparently not available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about INR-STR
and INR-END
? I think these are "instrument rotator at start" and "instrument rotator at end". There's also INST-PA
which must be "instrument position angle".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Do you have specifications for any of these? I would like to know exactly what 0 and 90 degrees mean for the orientation of N and E with respect to detector X and Y (assuming sky rotation, which seems most likely, but a similar question for any other kind of rotation).
INSTR-PA is in my sample HSC data, but not my sample sample Suprimecam data. It is probably the angle we want. INR-STR/END change over time and so are likely rotator mount angle (or similar), and if so, not useful enough to record in VisitInfo
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no comments on the HSC engineering data I looked at. Here's what I have from a Suprime-Cam frame (SUPA01270732.fits
):
INR-STR = 65.186 / [degree] Inst. rotator angle at start
INR-END = 65.185 / [degree] Inst. rotator angle at end
INST-PA = 90.000 / Position Angle of Instrument
Oooh! A more recent HSC exposure (HSCA08609518.fits
) has comments on the headers too:
INR-STR = -26.982 / [degree] Inst. rotator angle at start
INR-END = -26.982 / [degree] Inst. rotator angle at end
INST-PA = 0.000 / [degree] Position Angle of the Instrument Flang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The subprime data I have also has that comment; I just don't know what "Position Angle of the Instrument" actually means. I could guess, but it is safer not to!
from __future__ import print_function | ||
|
||
import astropy.units | ||
import astropy.time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused import.
7ea0be4
to
39c8e7f
Compare
I made all suggested changes, rebased and pushed. I documented the possibilities for setting rotator angle but did not implement them yet for lack of necessary information. It is trivial to add this later when the information becomes available. |
standardizeCalib is no onger required because lsst.daf.base.exposureFromImage can now do the job.
39c8e7f
to
8826dad
Compare
Note: I also looked for Calib.getExptime, Calib.getMidTime and Calib.setMidTime but did not find them.
No description provided.