Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-31324: add step4 and step5 #377

Merged
merged 2 commits into from Aug 5, 2021
Merged

DM-31324: add step4 and step5 #377

merged 2 commits into from Aug 5, 2021

Conversation

yalsayyad
Copy link
Contributor

No description provided.

Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on step5 description.


If run with tract or patch in the data query, drpAssociation and
drpDiaCalculation will be complete, but the outputs of
consolidateDiaSourceTable not complete visits.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like obs_lsst, I don't understand this sentence, it's missing a verb. Also, should this be run with a tract or patch or without a tract or patch? That's not clear.

drpDiaCalculation will be complete, but the outputs of
consolidateDiaSourceTable not complete visits.

This subset is separate to signal to operators to hold to assess
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a bit confused with the meaning of "hold to assess". Perhaps "pause to assess" instead?

@yalsayyad yalsayyad merged commit 904645e into master Aug 5, 2021
@yalsayyad yalsayyad deleted the tickets/DM-31324 branch August 5, 2021 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants