DM-31489: Update StrayLightData to use FitsGenericFormatter with a deferred data set #381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the
SubaruStrayLightDataFormatter
a subclass ofFitsGenericFormatter
, and implements areadFits
method to do so. The reads differ between the butler generations:IsrTask.readIsrData
callsSubaruStrayLightTask.readIsrData
, which checks if the exposure needs correcting, and if so, calls theSubaruStrayLightData.readFits
method.SubaruStrayLightData.run
is called in the standard point inIsrTask.run
.DeferredDatasetHandle
is passed toIsrTask.run
which callsSubaruStrayLightData.run
at the standard point. Therun
method calls the same check method as in Gen2 (indicating this is run twice in Gen2), and if a correction is needed, converts the handle into the real object.There are some slight naming clarifications (
hdulist
->calib.ampData
) and the docstrings in edited files have been converted to DM standards.