Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-31489: Update StrayLightData to use FitsGenericFormatter with a deferred data set #381

Merged
merged 6 commits into from Aug 26, 2021

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Aug 24, 2021

This change makes the SubaruStrayLightDataFormatter a subclass of FitsGenericFormatter, and implements a readFits method to do so. The reads differ between the butler generations:

  • Gen2: IsrTask.readIsrData calls SubaruStrayLightTask.readIsrData, which checks if the exposure needs correcting, and if so, calls the SubaruStrayLightData.readFits method. SubaruStrayLightData.run is called in the standard point in IsrTask.run.
  • Gen3: A DeferredDatasetHandle is passed to IsrTask.run which calls SubaruStrayLightData.run at the standard point. The run method calls the same check method as in Gen2 (indicating this is run twice in Gen2), and if a correction is needed, converts the handle into the real object.

There are some slight naming clarifications (hdulist -> calib.ampData) and the docstrings in edited files have been converted to DM standards.

@czwa czwa requested a review from natelust August 24, 2021 21:29
@czwa czwa merged commit 80d499c into master Aug 26, 2021
@czwa czwa deleted the tickets/DM-31489 branch August 26, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants