Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs_subaru DM-1954: HeavyFootprints in forced coadd photometry #4

Merged
merged 3 commits into from Aug 13, 2015

Conversation

TallJimbo
Copy link
Member

No description provided.


# Disable Gaussian mags (which aren't really forced)
root.measurement.algorithms.names -= ["base_GaussianFlux"]
root.measurement.algorithms.names |= ["base_SdssShape"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be running SdssShape in forced mode, either here or in forcedPhotCoadd.py, below; it's not actually a forced measurement, and it doesn't look like we're running it there on the HSC side. Did you find that you had to run it for some reason, or is my assertion that we're not running it on HSC incorrect?

And actually, It think we can remove the line above (and again in forcedPhotCoadd.py), since we've fixed GaussianFlux on the LSST side such that it actually does do forced photometry (it's not PSF-corrected, but neither are the aperture magnitudes).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I added that to have more measurements to compare with in the forced vs. meas catalogs. I'll remove it and the one above in both files.

@TallJimbo
Copy link
Member Author

I don't think we need the forcedCcd.py and forcedCoadd.py config files anymore (if we do, it means we're inconsistent somewhere in what we call these tasks, and that should be fixed). I see that they're present on the HSC side as well, but I think they're similarly useless there.

@laurenam laurenam merged commit c2adb2f into master Aug 13, 2015
TallJimbo pushed a commit that referenced this pull request Feb 28, 2017
DM-5879 Remove use of Boost smart pointers throughout the Science Pipelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants