obs_subaru/DM-7884: unification of coadd and diff datasets #40
Conversation
deepCoadd_depth, deepCoadd_bg, deepCoadd_bgRef, deepCoadd_forced + _schema modelfits + _schema deepCoadd_modelfits + _schema, deepCoadd_multiModelfits + _schema diffsources + _schema diffpsf diff crDiffim, crDiffimSrc + _schema
Datasets which are defined in obs_base may differ from those defined in the Mapper.paf file only in the template or tables entries. Remove those parts of the dataset definiton which do not differ.
| @@ -750,11 +701,9 @@ datasets: { | |||
| # Measurements on coadds | |||
|
|
|||
| # Reference catalog for coadds | |||
| # dataset defined in obs_base modified in this mapper as follows: | |||
There was a problem hiding this comment.
This python entry is definitely incorrect: it refers to the base class of the config class we want. I suspect obs_base has the right one.
There was a problem hiding this comment.
I have this fix listed on RFC-237. Will do it next week.
| } | ||
| # dataset defined in obs_base modified in this mapper as follows: |
There was a problem hiding this comment.
This python entry is incorrect. It should point to a class in meas.base, not pipe.tasks. Hopefully that change will bring it into agreement with obs_base.
There was a problem hiding this comment.
I have this fix listed on RFC-237. Will do it next week.
| storage: "FitsStorage" | ||
| level: "Skytile" | ||
| tables: "raw_skytile" | ||
| } | ||
|
|
There was a problem hiding this comment.
Please don't leave two blank lines.
| persistable: "Psf" | ||
| storage: "BoostStorage" | ||
| tables: "raw_skytile" | ||
| } | ||
|
|
| storage: "FitsStorage" | ||
| level: "Skytile" | ||
| tables: "raw_skytile" | ||
| } | ||
|
|
| persistable: "Psf" | ||
| storage: "BoostStorage" | ||
| tables: "raw_skytile" | ||
| } | ||
|
|
| @@ -514,11 +514,9 @@ datasets: { | |||
| tables: "raw" | |||
| tables: "raw_visit" | |||
| } | |||
| # dataset defined in obs_base modified in this mapper as follows: | |||
| deepCoadd_calexp_background: { | |||
| template: "deepCoadd-results/%(filter)s/%(tract)d/%(patch)s/det_bkgd-%(filter)s-%(tract)d-%(patch)s.fits" | |||
There was a problem hiding this comment.
Why is the HSC template different? Is there a reason not to just adopt the obs_base one?
| @@ -527,17 +527,13 @@ datasets: { | |||
| tables: raw | |||
| tables: raw_visit | |||
| } | |||
| # dataset defined in obs_base modified in this mapper as follows: | |||
| forced_src_schema: { | |||
| template: "schema/forced_src.fits" | |||
There was a problem hiding this comment.
Again, I think we should use what's in obs_base unless there's a good reason not to.
No description provided.