DM-28334: Replace afw.image.Filter name usage with explicit map. #412
Conversation
| value from the short one (e.g. 'r') declared canonical in afw.image.Filter. | ||
|
|
||
| def getPhysicalFilterName(short): | ||
| """Return am HSC physical_filter name (e.g. 'HSC-R') that's usable as a |
| if short == filter.afw_name or short == filter.band: | ||
| return filter.physical_filter | ||
| return short | ||
| if short.startswith("N"): |
There was a problem hiding this comment.
Might be worth a comment above this that it's just here for the narrowband filters?
| @@ -36,20 +35,23 @@ | |||
|
|
|||
| HSC_BEGIN = "2012-12-18" # initial date for curves valid for entire lifetime of HSC | |||
|
|
|||
| OLD_FILTER_NAME_MAP = {b: f"HSC-{b.upper()}" for b in "grizy"} | |||
| OLD_FILTER_NAME_MAP.update(r2="HSC-R2", i2="HSC-I2") | |||
There was a problem hiding this comment.
Should we have a comment above this saying something like "this is to map physical filter names to the deprecated afw names", for future readers?
|
Also:
Can't we fix the files? |
Yes, these are still run:
I just don't think it's worth it. |
We have a few data files committed to git here that use various old names for filters. It's best to just have an explicit constant mapping for those.
TallJimbo
force-pushed
the
tickets/DM-28334
branch
from
18cb396
to
3d549ff
Compare
We have a few data files committed to git here that use various old names for filters. It's best to just have an explicit constant mapping for those.