DM-33429: Add ability to do both serial and parallel overscan correction #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
approved these changes
Jul 14, 2022
config/isr.py
Outdated
| config.overscanBiasJumpLocation = -1 | ||
| config.overscan.leadingColumnsToSkip = 0 | ||
| config.overscan.trailingColumnsToSkip = 0 | ||
| config.overscan.maxDeviation = 1000.0 |
There was a problem hiding this comment.
Aren't these the defaults? Then can't we just remove them?
* Overscan should now be configured via the OverscanTask's config object. * Overscan parameters that use the default values have had those duplicates removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch config file to use current overscan config options instead of deprecated isrTask config options.