DM-9004: Check uses of darktime for NAN #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not recorded in the header, so set it to the exposureTime. Unfortunately, that's the best we can do. It needs to be set explicitly, or it will be NAN.
r-owen
reviewed
Jan 16, 2017
| @@ -192,7 +192,7 @@ def std_raw(self, item, dataId): | |||
|
|
|||
| def std_dark(self, item, dataId): | |||
| exposure = self._standardizeExposure(self.calibrations['dark'], item, dataId, trimmed=False) | |||
| visitInfo = afwImage.makeVisitInfo(exposureTime=1.0) | |||
| visitInfo = afwImage.makeVisitInfo(exposureTime=1.0, darkTime=1.0) | |||
There was a problem hiding this comment.
This looks fine. However, I am curious why darks don't already have correct exposure time (at least), a question that is out of scope, but left over from when I first added VisitInfo support to obs_subaru.
There was a problem hiding this comment.
The dark construction script has never set the dark time. I'll address that in DM-8913.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.