Review of DM-3493 (Fix crosstalk following ds9 interface changes) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -511,16 +513,16 @@ def fixCcd(butler, visit, ccd, coeffs, display=True): | |||
| """Apply cross-talk correction to a CCD, given the cross-talk coefficients""" | |||
| mi = readImage(butler, visit=visit, ccd=ccd) | |||
| if display: | |||
| ds9.mtv(mi.getImage(), frame=0, title="CCD %d" % ccd) | |||
| frame1 = afwDisplay.getDisplay(backend="ds9", frame=1) | |||
There was a problem hiding this comment.
Is it necessary to hard-code the ds9 backend here? It should be the default unless the user has overridden it -- and if they have, we presumably want to respect their choices unless this code actually requires ds9.
There was a problem hiding this comment.
It looks as though we previously put the pre-subtraction image in frame 0 and the post-substraction in frame 1. You seem to be putting both in 1. Is that deliberate?
PaulPrice
force-pushed
the
tickets/DM-3493
branch
from
c4c657f
to
9db9741
Compare
Use of lsst.afw.display.ds9 now fails if new package display_ds9 is not setup. Converted to use the new interface. The "setMaskVisibility" function doesn't appear to have a successor, so its use has been removed.
To ensure the temporary mask plane is removed, put the removal in the 'finally' clause.
PaulPrice
force-pushed
the
tickets/DM-3493
branch
from
9db9741
to
9338dd8
Compare
TallJimbo
pushed a commit
that referenced
this pull request
Feb 28, 2017
Change from boost::math to std
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.