Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move variance update after bias correction #61

Merged
merged 1 commit into from Mar 30, 2017
Merged

Move variance update after bias correction #61

merged 1 commit into from Mar 30, 2017

Conversation

SimonKrughoff
Copy link
Contributor

No description provided.

PaulPrice
PaulPrice approved these changes Mar 1, 2017
View reviewed changes
Copy link
Contributor

@PaulPrice PaulPrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the changes.
Please mention in the commit message that this change is coordinated with changes to CCD assembly in ip_isr so it's clear why the change was made.

@SimonKrughoff
Move variance update after bias correction
c1896c3 
With the removal of the requirement that assembly take images with a variance plane
this allows for amp assembly to be done in a more correct order.  This also means
that at the point that the variance plane is updated the assembled ccd has been trimmed
of prescan/overscan regions.
@SimonKrughoff SimonKrughoff merged commit c1896c3 into master Mar 30, 2017
@ktlim ktlim deleted the tickets/DM-4232 branch August 25, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulPrice PaulPrice PaulPrice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimonKrughoff @PaulPrice