DM-9111 Add rotator information to HSC VisitInfo #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
requested changes
Mar 13, 2017
| # Rotation angle formula determined empirically from visual inspection | ||
| # of HSC images. See DM-9111. | ||
| rotAngle = 270.0*degrees - self.popAngle(md, "INST-PA") | ||
| rotAngle.wrap() |
There was a problem hiding this comment.
As of a few days ago Angle.wrap returns a new Angle rather than operating in place, so this code requires a minor change. The following should work, or you can break it into two lines if you prefer:
rotAngle = (270.0*degrees - self.popAngle(md, "INST-PA")).wrap()
There was a problem hiding this comment.
Ah, great! I had actually originally tried to use .wrap() as you suggest, but I guess this was before the update since it failed at the time. Change implemented.
jmeyers314
force-pushed
the
tickets/DM-9111
branch
from
36abeec
to
233bc89
Compare
Uses the formula boresightRotAngle = 270 - INST-PA where INST-PA is the position angle from the HSC file header. Also sets rotType to rotType.SKY.
jmeyers314
force-pushed
the
tickets/DM-9111
branch
from
233bc89
to
9330685
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.