Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-9190: Cleanup pybind11 remaining code #68

Merged
merged 1 commit into from Apr 6, 2017
Merged

DM-9190: Cleanup pybind11 remaining code #68

merged 1 commit into from Apr 6, 2017

Conversation

pschella
Copy link

No description provided.

r-owen
r-owen approved these changes Mar 28, 2017
View reviewed changes
Copy link
Contributor

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

The obs_subaru code could use a cleanup pass (e.g. rename Crosstalk.h to subtractCrosstalk.h to avoid collision with crosstalk.py, fix pep8 violations) but that seems out of scope.

r-owen
r-owen approved these changes Mar 28, 2017
View reviewed changes
Copy link
Contributor

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed one missing import the first time.

python/lsst/obs/subaru/__init__.py Outdated
from .subaruLib import *
from __future__ import absolute_import, division, print_function

import lsst.afw.geom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving this to hscDistortion.cc

python/lsst/obs/subaru/_crosstalk.cc Outdated
@@ -31,6 +31,8 @@ namespace lsst {
namespace obs {
namespace subaru {

// Note that _crosstalk is not related to the crosstalk Python module;
// unfortunately they do have the same name.
PYBIND11_PLUGIN(_crosstalk) {
py::module mod("_crosstalk");

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please import lsst.afw.image (here or in __init__.py)

@pschella pschella merged commit 7d6f562 into master Apr 6, 2017
@ktlim ktlim deleted the tickets/DM-9190 branch August 25, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-owen r-owen r-owen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pschella @r-owen