DM-9572: Include instrument model in cameraGeom #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonKrughoff
approved these changes
Apr 12, 2017
| radec = self.visitInfo.getBoresightRaDec() | ||
| ra = radec.getRa() | ||
| dec = radec.getDec() | ||
| era = self.visitInfo.getEra() |
There was a problem hiding this comment.
Note that this may not be exactly ERA. Since it's hard to compute it is typically an approximation. I don't know if it matters here.
There was a problem hiding this comment.
Thanks for the notice. I think approximate is good enough for now, but I'll keep this in mind going forward.
python/lsst/obs/hsc/hscPupil.py
Outdated
| cosq = np.sqrt(1 - sinq*sinq) | ||
| if dec > lat: | ||
| cosq = -cosq | ||
| q = Angle(np.arctan2(sinq, cosq)) |
There was a problem hiding this comment.
I think the style guide suggests avoiding single character variable names.
| @@ -147,6 +145,19 @@ def testRaw(self): | |||
| self.assertAlmostEqual(weather.getAirPressure(), self.weath_airPressure) | |||
| self.assertAlmostEqual(weather.getHumidity(), self.weath_humidity) | |||
|
|
|||
| def testPupil(self): | |||
| """Test retrieval of pupil (without checking value)""" | |||
There was a problem hiding this comment.
Don't you care that it's at least an HscPupilFactory? That seems relatively easy to test.
jmeyers314
force-pushed
the
tickets/DM-9572
branch
3 times, most recently
from
42d9d26
to
0db3425
Compare
Subclass of pupilFactory tailored for HSC.
... which in turn attaches an hscPupilFactory to a Camera instance.
jmeyers314
force-pushed
the
tickets/DM-9572
branch
from
0db3425
to
4ad0239
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.