HscMapper: cache the camera object #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lion's share of the time in instantiating a butler goes to building the camera object, because that involves parsing a Config with many lines, and a stat call for each line to get the traceback. We cache the camera once it's built so that subsequent butler instantiations (e.g., for multiprocessing or pipe_drivers) don't suffer the same overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lion's share of the time in instantiating a butler goes to
building the camera object, because that involves parsing a Config
with many lines, and a stat call for each line to get the traceback.
We cache the camera once it's built so that subsequent butler
instantiations (e.g., for multiprocessing or pipe_drivers) don't
suffer the same overhead.